fdionisi / xray

An experimental next-generation Electron-based text editor
MIT License
47 stars 0 forks source link

Hyperapp V2 instead of React as UI framework #7

Closed B-Teague closed 5 years ago

B-Teague commented 5 years ago

Have you looked at hyperapp V2? It's pretty amazing. https://github.com/jorgebucaran/hyperapp

Build UI components. Built in state management Supports class attribute for use with CSS-in-JS libraries

Fast and small. Benchmarks: https://github.com/jorgebucaran/hyperapp/issues/523#issuecomment-417838623 https://codesandbox.io/s/k3jj2qlpk5

fdionisi commented 5 years ago

At this moment in time I see the current UI as a way to test the actual Rust core – it's minimal and far from production ready. That said, I mostly agree with arguments previously made in https://github.com/atom/xray/issues/12 and https://github.com/atom/xray/issues/41.

In the future React could be reconsidered in favour of something else, but for now it's doing the job.

I know that in my initial thoughts there were more UI work to happen sooner then later, but I actually diverged from the roadmap described in #1, and I'm now trying to integrate Memo into Xray – after that there are more core functionalities that I want to implement, such as syntax highlight and language server protocol, therefore I see UI discussions far down the line. When it'll be time, I promise, I will try to evaluate every possibility keeping an open mind.