search

fdo-rs / fido-device-onboard-rs

An implementation of the FIDO Device Onboard (FDO) spec written in Rust.
BSD 3-Clause "New" or "Revised" License
63 stars 34 forks source link

chore(packit): add pre-sync to fix propose-downstream action #695

Closed runcom closed 4 days ago

runcom commented 4 days ago

fixed packit configuration to allow to build the vendor archive in propose downstream too - as it's bad to add conditionals around sources anyway https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_do_not_conditionalize_sources So, if we want just one shared specfile, this is the way :mandalorian:

runcom commented 4 days ago

fixed - @mmartinv ptal

F41 MR https://src.fedoraproject.org/rpms/fido-device-onboard/pull-request/6 rawhide MR https://src.fedoraproject.org/rpms/fido-device-onboard/pull-request/5

runcom commented 4 days ago

Fedora's MRs are green as well

runcom commented 4 days ago

rebased to latest main - not sure what @nullr0ute meant with "incorrect changes" here https://github.com/fdo-rs/fido-device-onboard-rs/pull/695#discussion_r1858109816 but this is very good to go finally (and automation works :man_dancing: )

runcom commented 4 days ago

Maybe we can take this opportunity to also include downstream updates for at least c10s now that it's supported? https://packit.dev/docs/configuration/upstream/propose_downstream#syncing-the-release-to-centos-stream

I honestly would get this done for 0.5.1 as it's been going out of scope from the original bug :smile: but we can tackle that immediately next to this :)

runcom commented 4 days ago

I honestly would get this done for 0.5.1 as it's been going out of scope from the original bug 😄 but we can tackle that immediately next to this :)

scratch that, I made it work :) pushing!