search

feathersjs-ecosystem / feathers-objection

Feathers database adapter for Objection.js, an ORM based on KnexJS SQL query builder for Postgres, Redshift, MSSQL, MySQL, MariaDB, SQLite3, and Oracle. Forked from feathers-knex.
MIT License
98 stars 48 forks source link

Remove groupBy when counting rows for pagination #150

Closed gmercey closed 3 years ago

gmercey commented 3 years ago

When counting rows for the pagination, groupBy is not necessary as we only need 1 row and groupBy can return multi-row when using join relation and $in operator in the where clause.

dekelev commented 3 years ago

Thanks @gmercey , released in v7.2.0