search

feathersjs / docs

[MOVED] Legacy Feathers documentation
https://crow.docs.feathersjs.com/
MIT License
242 stars 531 forks source link

Fix errors in the Feathers guide #1557

Closed AtomicTroop closed 1 year ago

AtomicTroop commented 2 years ago

The TypeScript version of the guide has some missing "any" types in the tests added during the final section of the guide. This pull request fixes those omissions, matching the current state of feathers-chat-ts.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for feathers-docs ready!

🔨 Explore the source changes: a973160fd707f6237ae92e2f968f130ba4a7267f

🔍 Inspect the deploy log: https://app.netlify.com/sites/feathers-docs/deploys/61f85e9b494d8c0007b078c3

😎 Browse the preview: https://deploy-preview-1557--feathers-docs.netlify.app

AtomicTroop commented 2 years ago

I notice the mocha script in the "Writing tests" section of the guide uses ts-mocha while the feathers-chat-ts repo uses a more complex mocha command that matches and builds on what the current feathers project generator produces in package.json by default. Not sure if that should also be fixed?