search

feathersjs / feathers

The API and real-time application framework
https://feathersjs.com
MIT License
15.02k stars 745 forks source link

AuthenticationService setup fails when entity is undefined intentionally #3151

Closed nsainaney closed 1 year ago

nsainaney commented 1 year ago

I have a service that is authenticated RSA256 JWT tokens. The service runs in kubernetes and doesn't have an entity associated.

If entity is left bank in config files, the entity is undefined and not null. Should this check for undefined or be:

entity !== null and entity !== undefined

https://github.com/feathersjs/feathers/blob/a6ba4dfd08f537a7d4778bed4c45091cbe3802aa/packages/authentication/src/service.ts#L181

nsainaney commented 1 year ago

Sorry - just found the docs on stateless JWT