search

fecgov / fec-cms

The content management system (CMS) for the new Federal Election Commission website.
https://www.fec.gov
Other
98 stars 40 forks source link

Research replacing gulp-util #5569

Open cnlucas opened 1 year ago

cnlucas commented 1 year ago

Summary

What we're after: gulp-util is deprecated. They encourage everyone to move away from it and to open tickets in any dependencies that are still using it. We should research replacing it and replace if possible

https://www.npmjs.com/package/gulp-util

Related issues

List any relevant related issue(s)

Completion criteria

What does the end state look like? Include any behavior, appearance, etc required for this ticket to be 'complete.'

Tech steps or considerations (optional)

List any considerations the tech team should know. Additionally, any specific tech steps can be included here.

Future work

Other future work that may be needed following this issue's completion.

cnlucas commented 1 year ago

This is blocked by webpack upgrade neo-async is used by webpack 4 which uses gulp-util

jmetev1 commented 1 year ago

I read the article on Medium. And the impression I get is that by transitioning away you can have smaller packages (but only for your local repo since it's just a dev tool). But it doesn't seem like a security problem. They would like the people who make plugins to in the future not to use gulp-util. But it doesn't seem like a problem for this repo.

rfultz commented 4 days ago

@tmpayton Webpack has been upgraded and gulp-util is no longer mentioned in anything Webpack does.

But package-lock is telling me that gulp-css-urlencode-inline-svgs is still using gulp-util, which is only called when we use build-icons (which is rare).

Thoughts?