search

fedora-infra / fedora-tagger

Small tagger app for Fedora Community
https://apps.fedoraproject.org/tagger/
15 stars 23 forks source link

Catch and inform 500 of non-existing packages #100

Closed pypingou closed 10 years ago

pypingou commented 11 years ago

At the moment if a package does not exist, for example: https://apps.fedoraproject.org/tagger/testsasda tagger return a 500 error page.

Maybe we should catch this error, redirect to a random package and pop-up/display a message informing that package 'testsasda' could not be found.

ralphbean commented 11 years ago

Agreed. I just ran into this with https://apps.fedoraproject.org/tagger/hovercraft/

pypingou commented 10 years ago

So we have two issues here:

a) package does not exists: flask.flash() an error message and redirect to https://apps.fedoraproject.org/tagger/

b) the url has a trailing slash -> add a new controller that redirects to the endpoint with no trailing slash (required as otherwise jslink gets confused).

arielb2 commented 10 years ago

check this pleas https://github.com/fedora-infra/fedora-tagger/pull/154

Would it be possible to change the image of a hotdog like this http://picpaste.com/notfound-wzXkGh1k.png, when it can not find the packages?

ralphbean commented 10 years ago

I think @arielb2 closed this one out in #154. Closing!