search

fedspendingtransparency / usaspending-api

Server application to serve U.S. federal spending data via a RESTful API
https://www.usaspending.gov
Creative Commons Zero v1.0 Universal
309 stars 112 forks source link

[DEV-11211] - Create new Program Activity autocomplete endpoint #4138

Closed ronaldongbah closed 4 months ago

ronaldongbah commented 4 months ago

Description: In order to support the new changes to the State Profile Pages as well as Advanced Search, a new Program Autocomplete endpoint is created so that users are able to search by Program Activity code or name.

Technical details: The technical details for the knowledge of other developers. Any detailed caveats or specific deployment steps should be outlined here.

Requirements for PR merge:

  1. [x] Unit & integration tests updated
  2. [x] API documentation updated
  3. [x] Necessary PR reviewers:
    • [x] Backend
  4. [x] Jira Ticket DEV-11211:

Area for explaining above N/A when needed:

ghost commented 4 months ago

@ronaldongbah Looks like the code climate issues are a misconfiguration in your local flake8/black settings? Has Booze Allen not passed along the correct settings? If they haven't, reach out to me and I can. :) It's a very simple fix to get your PR merged now that I approved it, and I can give you a solution that's automated (so you never have to worry about this code climate failure).

ronaldongbah commented 4 months ago

@dporth-frb I do not have those configs set up. We are planning on meeting tomorrow morning after stand-up to get that set up correctly and automated.

ghost commented 4 months ago

@dporth-frb I do not have those configs set up. We are planning on meeting tomorrow morning after stand-up to get that set up correctly and automated.

Cya then!

ronaldongbah commented 4 months ago

@dporth-frb I pushed the changes to this PR for whenever you have time to review it again!