search

feldim2425 / MoreOverlays

MC Mod : Brings back some of the NEI Overlays ( Mob Spawns, Chunk Bounds, Item Search)
MIT License
22 stars 18 forks source link

Shader Compatibility #6

Closed jjc54 closed 6 years ago

jjc54 commented 8 years ago

None of the overlay features work when any shader packs are being used. Tested with Sildur/MrMeeps. Not sure if you need anything from me but just let me know if you do.

feldim2425 commented 8 years ago

Can you please tell me the Forge version, MC version and the Shader Mod / Optifine Version?

jjc54 commented 8 years ago

Minecraft: 1.9 Forge: forge-12.16.0.1859 Shader mod has been incorporated into Optifine: preview_OptiFine_1.9.0_HD_U_B2_pre (You will find that here: http://optifine.net/downloads.php under the preview section at the top) Shaders: MrMeepz Shaders v05 Ultra Motionblur (http://tinyurl.com/pbaa7uy)

feldim2425 commented 8 years ago

I will try but I don't think that there is a way to fix this. I think the Optifine version is not a Forgeversion and it is closed source. Probably Optifine messes up Forge.

jjc54 commented 8 years ago

Oh ok I'll switch to a forge version once optifine updates to the latest forge. Thanks

jriwanek commented 8 years ago

The preview version of optifine gets updated sometimes without the filename changing, currently (as of 04/13/2016) it's been rebased against 1863, @feldim2425 Not sure where you got the idea it's not a forge compatible, it has been since the late A? Releases, official "stable" for 1.9 is also forge compatible but with 1797.

jriwanek commented 8 years ago

See changelog: http://www.optifine.net/changelog?f=preview_OptiFine_1.9.0_HD_U_B2_pre.jar (07.04.2016)

Also see the date under "preview versions": http://www.optifine.net/downloads (13.04.2016)

feldim2425 commented 8 years ago

@jriwanek It didn't worked in the dev-environment. I will try it in a normal Minecraft instance. I hope it works. I'm not a huge fan of OptiFine. Last time I used it was in MC 1.6.4

feldim2425 commented 8 years ago

Ok I looked why it doesn't work. Screenshot (It is very dark and it doesn't render from every angle): 2016-04-15_22 12 30

But I found this on the forum post for MrMeepz Shaders v05 in the Download section: " This Shaderpack is optimized for Minecraft 1.7, the result in 1.8 is too dark and washed out and looks by far not as good as in 1.7. If you want to get the best result, use Minecraft 1.7 instead. "

EDIT: You can also see that on the blocks in the village on the screenshot I will try some other shaders if something similar happens.

jriwanek commented 8 years ago

The problem is that Optifine disables the Forge Rendering pipeline, I think a fix in progress, but I suspect it'll take a while to get done, hopefully somehow optifine's rendering pipeline can be jimmied onto Forge's and everything can be made to work together properly. I doubt however this can be considered a bug in More Overlays though.

jjc54 commented 8 years ago

Ah okay, I have already made an issue about Optifine's forge rendering pipeline and it is being worked on. Not sure if it will be fixed in 1.9 since Optifine is now 1.9.2, but the problem is known.

By the way, I know MrMeepz is "optimized for 1.7" but I did say that I used several other packs, with none allowing More Overlays to work.

feldim2425 commented 8 years ago

Optifine is closed source so I can't look whats messing up the tessellator. Even if it is open source it will be to much code to check where the problem is. I tried some stuff like enabling GLBlend, ... and it doesn't change anything. Also I didn't found any code in Vanilla MC or on GitHub that can bypass shaders.

If the bug is only in More Overlays it should also appear in "Vanilla" MC and if a part of the bug is in this Mod I don't know what I have to change.

If anyone has an idea how to fix this bug, please make a Pull Request or write a comment in this Issue.

feldim2425 commented 8 years ago

I still work on a fix. I fixed at least the invisible lines. But there are still some bugs.

2016-07-04_12 26 44

EDIT: I will do some other stuff from my todo-list and hopefully I can upload a new version soon.

feldim2425 commented 8 years ago

Ok I uploaded a version (1.5) that should fix at least the invisible lines (at least in some packs) but I will not close this because they are still a bit bugy (like in the screenshot in my last comment)

feldim2425 commented 6 years ago

I will close this one. The borders show up (at least) and even Vanilla chunk lines are buggy with shaders. So I will say this is a issue that optifine has to fix. I don't see why other mods have to fix it when shaders break into the rendering pipeline.