search

felipeochoa / rjsx-mode

A JSX major mode for Emacs
https://github.com/felipeochoa/rjsx-mode
MIT License
639 stars 32 forks source link

rjsx-mode should inherit from js2-mode, not js2-jsx-mode #104

Closed bzalasky closed 5 years ago

bzalasky commented 5 years ago

Since rjsx-mode defines its own indent-line-function, it’s not gaining anything from that inheritance currently, and js2-jsx-mode is unlikely to provide useful heritable setup code in the future either.

Since rjsx-mode’s indentation is implemented without any reference to Emacs <=26’s js-jsx-indent-line, it should continue to work fine.

Originally posted by @jacksonrayhamilton in https://github.com/mooz/js2-mode/issues/532#issuecomment-500661240