search

felixdoerre / primus_vk

Vulkan GPU-offloading layer
BSD 2-Clause "Simplified" License
229 stars 17 forks source link

Add wrapper icd #16

Closed Thaodan closed 5 years ago

Thaodan commented 5 years ago

credit goes to /leomaxx/ the creator of the [[https://github.com/leonmaxx/primus-vk-rpm][rpm package]].

felixdoerre commented 5 years ago

Why not call it nv_vulkan_wrapper.json to fit the corresponding source file?

Thaodan commented 5 years ago

Because I marched the rpm pkg. I renamed the file according to your suggestion.

felixdoerre commented 5 years ago

Discussion on another issue made me thinking: We'd have to adjust the version to the version of the nvidia-json file. So having such a file fit all nvidia drivers is not possible.

Thaodan commented 5 years ago

Than use is as default an edit the version at build/install time?

felixdoerre commented 5 years ago

Yes, that would be the best we could do, without being explicitly triggered by installations of the nvidia driver. If that's not possible, maybe adding a sanity check to pvkrun could help users who changed the installed nvidia driver after installing primus-vk.

Thaodan commented 5 years ago

You can depend on the current nvidia driver at build time. A hook would be possible to however this shouldn't go to /usr. I think thats something that needs to be watched for at package level.