felixjones / github-mgba-rom-test

GitHub Action for unit-testing Game Boy and Game Boy Advance ROMs via mGBA's rom-test frontend
8 stars 1 forks source link

Locate binary using github action path #3

Closed Anders429 closed 7 months ago

Anders429 commented 7 months ago

After reading the github action docs a bit, I believe the reason #2 is happening is because the github action's path is not the same as the runner's action path. Therefore, the action looks for the binary within my repository's directory, instead of its own. This isn't a problem when you run tests located within the same repository, but it is when an external repository tries to use the action.

I've put together a quick PR to fix this. It simply locates the binary using the action's path. I've tested this using a fork and verified it works.