felixschndr / mealie-bring-api

A simple webserver that allows ingredients sent by mealie to be added to a bring shopping list
11 stars 2 forks source link

fix(Dockerfile): Changed source python package and copy commands to make container work on raspberry pi #6

Closed L3-N0X closed 1 week ago

L3-N0X commented 3 months ago

This PR contains my changes to the Dockerfile

felixschndr commented 3 months ago

Thank you very much. When I got time I will take a closer look at checking this out and testing a bit with a RPi myself

L3-N0X commented 3 months ago

Hi, I had space problems with my raspberry pi and noticed, that the python-bookworm packages take up like 1GB of space. I changed back to -alpine and built the container again and it still works, so changing to python-bookworm is not necessary and is also not good considering the huge amount of space this base image needs.

felixschndr commented 3 weeks ago

I'd like to merge this. @guidalencon is it not possible to run the -alpine version on MAC?

As said in https://github.com/felixschndr/mealie-bring-api/pull/6#issuecomment-2284380788 bookworm takes up 300MB more in space. Is it not possible to run alpine on mac?

┌─[22:27:22]-[:)]-[fschneider@ws-win-00388]-[WSL]-[/home/fschneider/repos/personal/mealie-bring-api/ (use-bookwork-image)]
└──> docker inspect -f "{{ .Size }}" ghcr.io/felixschndr/mealie-bring-api:use-bookwork-image
1042771328

┌─[22:28:04]-[:)]-[fschneider@ws-win-00388]-[WSL]-[/home/fschneider/repos/personal/mealie-bring-api/ (use-bookwork-image)]
└──> docker inspect -f "{{ .Size }}"  ghcr.io/felixschndr/mealie-bring-api:main
74492057
felixschndr commented 3 weeks ago

Seems like bookworm may be the way to go as only then @Menthe11 was able to use the image https://github.com/felixschndr/mealie-bring-api/issues/3#issuecomment-2256391281

guidalencon commented 2 weeks ago

Hey @felixschndr, sorry for the delayed answer! I've tested with both alpine and bookworm and both work on my machine!

felixschndr commented 1 week ago

Okay, then I will close this PR as the changes proposed are already present in the main branch (https://github.com/felixschndr/mealie-bring-api/blob/main/Dockerfile)