[Update APP] Added custom charset in random-string-generator

felvin-search / instant-apps

Your search box is now an app store! 🎉

https://felvin.com

Other

95 stars 47 forks source link

[Update APP] Added custom charset in random-string-generator #215

Closed Kartiksaini001 closed 3 years ago

Kartiksaini001 commented 3 years ago

Features:

Added an option to give a custom character set to generate random strings.

Screenshot:

sahil-shubham commented 3 years ago

@Kartiksaini001 This doesn't seem to contain only the new changes, as it should. It would be good if you make pull requests from a new branch and not from the master directly, which here is behind the upstream.

Can you go ahead and fix the conflicts or make a new pull request with the new additions.

Kartiksaini001 commented 3 years ago

@sahil-shubham The issue might have been resolved now

Kartiksaini001 commented 3 years ago

@sahil-shubham I don't have permission to resolve conflicts

sahil-shubham commented 3 years ago

@Kartiksaini001 I am closing this pull request, sync the master branch of your fork then make a pull request with only the changes included in the commit (preferably with new branch) - https://github.com/felvin-search/instant-apps/pull/215/commits/e9198c80783673a416ca06367b00cf5bb2b4105b.

It's better to rebase your branch rather than have a merge commit it. Your pull request should only contain additions and not the work that's already in the upstream's master branch.