Previously we grow the width/height to fit with the new aspect-ratio.
This PR changes the calculation: now we changes both the width and height while keeping the original area, which in theory would fit a better UX, especially when take in account of (#1161 aspect-ratio reactivity)
Without this PR, #1161 would behave as follow: the selection area being grown out of view when input changes, especially for dynamic user inputted usage.
Summary
What kind of change does this PR introduce? (check at least one)
[ ] Bugfix
[x] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:
If changing the UI of the default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
There is a behavior change, prob breaking?
[ ] Yes
[ ] No
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
You have tested in the following browsers: (Providing a detailed version will be better.)
[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] IE
If adding a new feature, the PR's description includes:
[x] A convincing reason for adding this feature
[ ] Related documents have been updated
[ ] Related tests have been updated
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Previously we grow the width/height to fit with the new aspect-ratio.
This PR changes the calculation: now we changes both the width and height while keeping the original area, which in theory would fit a better UX, especially when take in account of (#1161 aspect-ratio reactivity)
Without this PR, #1161 would behave as follow: the selection area being grown out of view when input changes, especially for dynamic user inputted usage.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of the default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one) There is a behavior change, prob breaking?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: