fengyuanchen / cropperjs

JavaScript image cropper.
https://fengyuanchen.github.io/cropperjs/
MIT License
13.14k stars 2.42k forks source link

feat(cropper-selection): uses `getAdjustedSizesKeepArea()` for aspectRatio calculation #1162

Closed NamesMT closed 7 months ago

NamesMT commented 7 months ago

Previously we grow the width/height to fit with the new aspect-ratio.

This PR changes the calculation: now we changes both the width and height while keeping the original area, which in theory would fit a better UX, especially when take in account of (#1161 aspect-ratio reactivity)

Without this PR, #1161 would behave as follow: the selection area being grown out of view when input changes, especially for dynamic user inputted usage.

Summary

What kind of change does this PR introduce? (check at least one)

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one) There is a behavior change, prob breaking?

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

You have tested in the following browsers: (Providing a detailed version will be better.)

If adding a new feature, the PR's description includes:

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

NamesMT commented 7 months ago

The commits got mixed up a bit, I'm closing to open a new one