fengyuanchen / cropperjs

JavaScript image cropper.
https://fengyuanchen.github.io/cropperjs/
MIT License
13.14k stars 2.42k forks source link

fix: regex expressions - anchors not being respected #1211

Closed BakerNet closed 2 weeks ago

BakerNet commented 1 month ago

Summary

Regexs like /^a|b|c$/ match a at start of text, c at end of text, or b. I assume this does not match the original intent.

This moves the union into a capture group so ^ and $ are respected for the whole union and not just a couple members of the union.

What kind of change does this PR introduce? (check at least one)

If changing the UI of the default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

You have tested in the following browsers: (Providing a detailed version will be better.)

If adding a new feature, the PR's description includes:

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

image