Device shown as BAD despite `power/control` being `on`

fenrus75 / powertop

The Linux PowerTOP tool -- please post patches to the mailing list instead of using github pull requests

http://www.01.org/powertop

GNU General Public License v2.0

1.04k stars 132 forks source link

Device shown as BAD despite `power/control` being `on` #148

Closed paulmenzel closed 6 months ago

paulmenzel commented 6 months ago

https://github.com/fenrus75/powertop/blob/4bdfba189864d699621708fea182db292edc9305/src/tuning/runtime.cpp#L90-L100

This only returns GOOD, if power/control is set to auto. Why is on not considered GOOD?

On the Dell XPS 13 9360, three PCI devices are shown as BAD:

$ more /sys/bus/pci/devices/0000:00:1f.0/power/control
on
$ more /sys/bus/pci/devices/0000:3a:00.0/power/control
on
$ more /sys/bus/pci/devices/0000:3b:00.0/power/control
on

paulmenzel commented 6 months ago

Fixed by commit https://github.com/fenrus75/powertop/commit/9beafe3bd5e9d4c6cf2596dacdf6ab9c9be0c85e as reported by @fenrus75 in their list reply.