fermyon / installer

Fermyon Installer
https://fermyon.dev
Apache License 2.0
158 stars 38 forks source link

Fermyon-branded Hippo #48

Closed bacongobbler closed 2 years ago

bacongobbler commented 2 years ago

EDIT: now working with both the local and AWS installers. Ready for review!

Currently working through a style sheet bug, but here's a preview!

image

The color scheme from fermyon/styleguide is not being applied to the project. Currently working through that. Hold up

bacongobbler commented 2 years ago

Okay... This is not my best code, but I could not see a way to get artifacts to overwrite assets prior artifacts downloaded without performing a mv after fetching the asset down.

That being said, things are working!

bacongobbler commented 2 years ago

Current output from latest local installer test:

image

bacongobbler commented 2 years ago

Now working with the AWS installer:

image

bacongobbler commented 2 years ago

Good question.

The logo.svg comes from fermyon.com's embedded logo, but with a few tweaks to the XML metadata so it can stand alone. I just realized there's a standalone version at https://github.com/fermyon/styleguide/blob/main/image/fermyon.svg. I will go and update that URL.

The favicon.ico is also available there, which may be a more stable resource: https://raw.githubusercontent.com/fermyon/styleguide/main/image/icon/favicon.ico

As for the styles.css, that comes from my local fermyon-branding branch of hippo. The styles.css is the end-result of a custom-compiled sass file that fixes a few issues with fermyon/styleguide and Bulma. These changes have been proposed upstream to https://github.com/fermyon/styleguide/pull/30, so eventually we could import fermyon.css from there.

As for config.json... We could just echo '{"title": "Fermyon"}' > config.json. There's no real need to pull that from an external source.

What do you think about that plan?

vdice commented 2 years ago

Awesome, thank you for the breakdown @bacongobbler .

I like the plan. Another idea, perhaps not necessarily mutually exclusive to the strategy you've laid out -- thoughts on a dedicated fermyon/hippo-styles (or, any name that might be better) holding all such assets dealing with Fermyon's custom branding on top of Hippo?

lann commented 2 years ago

I like the plan. Another idea, perhaps not necessarily mutually exclusive to the strategy you've laid out -- thoughts on a dedicated fermyon/hippo-styles (or, any name that might be better) holding all such assets dealing with Fermyon's custom branding on top of Hippo?

:+1: Nomad's artifact supports git repos too.

bacongobbler commented 2 years ago

Ideally fermyon/styleguide would be analogous to fermyon/hippo-styles. The only issue is that fermyon-base.scss messes up some styling on the topbar, which I will have to eventually work out and fix up. But yes, I can create a repository at some point to serve as an example.