search

fermyon / installer

Fermyon Installer
https://fermyon.dev
Apache License 2.0
158 stars 38 forks source link

fix(local): use rawexec for hippo jobs #57

Closed adamreese closed 2 years ago

adamreese commented 2 years ago

Fixes: #56

lann commented 2 years ago

...now can we get rid of sudo?

itowlson commented 2 years ago

Works on WSL. Haven't tested on Windows, Mac or "raw" Linux.

bacongobbler commented 2 years ago

We should be abundantly careful with this flag. I’m okay with this because it’s just for a demo repo, but because these jobs no longer run with any isolation systems in place, it is more likely a “host breakout” from the WASM runtime could incur more damage to the host system, potentially affecting other tenants’ applications.

I’d like to figure out why the exec driver works on Linux and not on WSL, but given that we’re so close to the release date, we should just go ahead with this and investigate later.

because the AWS demo runs on an EC2 instance, no change has to be applied there.