search

fernandojsg / aframe-4dof-controls-component

A-Frame 4DOF Component
https://fernandojsg.github.io/aframe-4dof-controls-component/index.html
MIT License
11 stars 3 forks source link

alternative name fourdof-controls #1

Open vincentfretin opened 6 years ago

vincentfretin commented 6 years ago

I tested the two examples, this component is great! Thanks for working on it!

I'm having difficulties to use 4dof-controls in a react project because eslint and prettier are complaining about identifier starting with number. Maybe we can register the component twice, one time with 4dof-controls and another one with fourdof-controls? What do you think?

For now I rename 4dof-controls to fourdof-controls in node_modules/aframe-4dof-controls-component/index.js

fernandojsg commented 6 years ago

I don't really like the name fourdof it not that readable and also it doesn't follow the convention of 3dof, 6dof. I'll think an alternative. And I'm welcome to any other proposals :D

vincentfretin commented 6 years ago

controls-4dof? hand-4dof-controls? In javascript, you can't start a variable name with a number, this is why eslint or prettier give a parsing error.