fernandojsg / aframe-input-mapping-component

https://fernandojsg.github.io/aframe-input-mapping-component
MIT License
24 stars 7 forks source link

Define mapping per controller/hand #16

Closed fernandojsg closed 6 years ago

fernandojsg commented 6 years ago

We should treat each controller as a separate device as you could have a painting state in a controller and grabbing in another. We could define specific mapping for each hand/controller we should have a way to set the current mapping per hand:

 AFRAME.setCurrentInputMapping(mappingName, hand);

The hand parameter could be optional and if not defined it will be applied to every controller.

I believe we don't need to modify the mappings structure itself as every task could be applied to each controller and is up to the application to do that (eg: we could define paint, grabbing, shooting and then set each mapping to the desired hand or use the same for both).

It's also strongly related to the handness issue: https://github.com/fernandojsg/aframe-input-mapping-component/issues/12. So the discussion here could be how to mix them both or if we really need to define the handeness once we have an specific way to define a mapping for each one. I personally don't see a user case where we need handness per event if we already could use a mapping per hand, but I'm open to suggestions!

fernandojsg commented 6 years ago

Closing it by now in favor to use mapping events per hand as specified on https://github.com/fernandojsg/aframe-input-mapping-component/issues/12