Closed fernandojsg closed 6 years ago
I prefer "state" but don't feel super strongly about it. Whichever it is, it should be consistent with AFRAME.currentMapping
and for both it might be nice to use the word "input":
mapping
-> AFRAME.currentInputMapping
state
-> AFRAME.currentInputState
@netpro2k yep, I forgot to change that :+1: @dmarcos tie-breaker! what you think? :)
I think the term state
is broad and might be confusing. A-Frame does not prescribe a way to define application states. Different mappings might nor not might map to whatever idea of state
each application decides to implement. I would prefer not to hold on the word state
and carry on with mappings
that is a more specific word. Those are my two cents.
Fine by me. id still go with naming the currently active one AFRAME.currentInputMapping
or AFRAME.activeInputMapping
though. I think AFRAME.currentMapping
is a bit too generic. Mapping of what?
Thanks for the feedback. Updated using currenInputMapping
Added the most conservatives changes from https://github.com/fernandojsg/aframe-input-mapping-component/issues/3
the structure now is:
I don't have an strong opinion about the naming on
states
ormapping
/cc @netpro2k @dmarcos