plugin messes with hex colors

[GitNether]

I've used this code in my server to translate hex codes, maybe you are able to reuse it. Then we'd be able to use your plugin again :)

public String translateHexColorCodes(String startTag, String endTag, String message)
    {
        final Pattern hexPattern = Pattern.compile(startTag + "([A-Fa-f0-9]{6})" + endTag);
        Matcher matcher = hexPattern.matcher(message);
        StringBuffer buffer = new StringBuffer(message.length() + 4 * 8);
        while (matcher.find())
        {
            String group = matcher.group(1);
            matcher.appendReplacement(buffer, COLOR_CHAR + "x"
                    + COLOR_CHAR + group.charAt(0) + COLOR_CHAR + group.charAt(1)
                    + COLOR_CHAR + group.charAt(2) + COLOR_CHAR + group.charAt(3)
                    + COLOR_CHAR + group.charAt(4) + COLOR_CHAR + group.charAt(5)
            );
        }
        return matcher.appendTail(buffer).toString();
    }

[festino]

Could you please tell me which color chat plugin you are using so I can easily reproduce?

[GitNether]

We're using EssentialsX.

Also, if you have a colored message, the link resets the color, and the message after it turns white. Maybe there is an easy way around that, just wanted to mention it.

[GitNether]

Another idea I had, which would probably be fairly easy to add since you already have the structure going on:

If there is a command in the message such as ./cmd or /cmd, you could make that clickable aswell to execute the command directly. Arguments could be added using smth like /cmd_arg1_arg2 to prevent it to interfere with the sentence (just as an idea I had).

[festino]

As a player with an underscore in my nickname, I would prefer not to use "_". The idea itself is not bad, you can open a feature request. =)

[festino]

Update: there was an incorrect assumption that color characters can only be in the format string. I need to implement style preserversion, so the fix will take some more time.

[festino]

I believe I fixed it with ac9fe05, but I will test it properly before releasing.

[GitNether]

If you release it, I'll test it on our server :)

[festino]

I have published a fix in the new release: https://github.com/festino-mc-plugins/ClickableLinks/releases/tag/v1.2.0 Check if the issue is gone. =)

[GitNether]

Hmmm.. seems like something else is still messing with the colors

[festino]

Ohhh I think I have added hex support for messages but not for nicknames 😅 Fortunately, now it’s easy to add this too.

[festino]

I believe it is fixed now https://github.com/festino-mc-plugins/ClickableLinks/releases/tag/v1.2.1 (I should request more information to reproduce, in the future) UPD. Will fix prefixes and postfixes soon

[GitNether]

Bad news

[festino]

Sorry for release flooding https://github.com/festino-mc-plugins/ClickableLinks/releases/tag/v1.2.2

[GitNether]

Colors work! :D

but bold is gone :o

[GitNether]

Also a funny bug

[festino]

Could you tell if any formatting (bold, etc) is currently working anywhere with the plugin?

[GitNether]

In the message it works

[GitNether]

any formatting turns purple though ^ i didnt put any color

[festino]

Oh, I see. Color codes should be inserted before formatting codes

[festino]

Also a funny bug

I don't understand what is going on. When I send "&4hello google.com 12345", extra "4" does not appear

[festino]

I have updated v1.2.2 jar, formatting is fixed https://github.com/festino-mc-plugins/ClickableLinks/releases/tag/v1.2.2

[GitNether]

Still no bold on my end, weirdly enough

[festino]

Could you temporarily enable "/links log-debug-info true" and copy-paste raw JSON of the message?

[GitNether]

&4 1234 google.com 1234 produced these two:

16.03 15:36:56 [Server] [INFO] [ClickableLinks] Sending raw JSON: [{"color":"#8701ff","text":"<"},{"color":"#fbf896","text":"★"},{"color":"#9062fe","text":"I"},{"color":"#aa87f7","text":"X"},{"color":"#fbf895","text":"★"},{"color":"#8701ff","text":"> "},{"color":"#FF0000","text":"["},{"color":"#E70505","text":"A"},{"color":"#CF0909","text":"D"},{"color":"#B70E0E","text":"M"},{"color":"#9F1313","text":"I"},{"color":"#871717","text":"N"},{"color":"#6F1C1C","text":"] "},{"color":"#fdfbff","text":"["},{"color":"#bf6bff","text":"I Voted✔"},{"color":"#fdfbff","text":"] "},{"color":"#240000","text":"N"},{"color":"#480000","text":"e"},{"color":"#6d0000","text":"t"},{"color":"#910000","text":"h"},{"color":"#b60000","text":"e"},{"color":"#da0000","text":"r"},{"color":"#fe0000","text":". "},{"text":"§7➣"},{"text":"§f "},[{"text":"§41234 "},{"text":"§4§ngoogle.com","clickEvent":{"action":"open_url","value":"https://google.com"}},{"text":"§4 1234"}]] 16.03 15:36:56 [Server] [INFO] [ClickableLinks] Sending raw JSON: [{"color":"#8701ff","text":"<"},{"color":"#fbf896","text":"★"},{"color":"#9062fe","text":"I"},{"color":"#aa87f7","text":"X"},{"color":"#fbf895","text":"★"},{"color":"#8701ff","text":"> "},{"color":"#FF0000","text":"["},{"color":"#E70505","text":"A"},{"color":"#CF0909","text":"D"},{"color":"#B70E0E","text":"M"},{"color":"#9F1313","text":"I"},{"color":"#871717","text":"N"},{"color":"#6F1C1C","text":"] "},{"color":"#fdfbff","text":"["},{"color":"#bf6bff","text":"I Voted✔"},{"color":"#fdfbff","text":"] "},{"color":"#240000","text":"N"},{"color":"#480000","text":"e"},{"color":"#6d0000","text":"t"},{"color":"#910000","text":"h"},{"color":"#b60000","text":"e"},{"color":"#da0000","text":"r"},{"color":"#fe0000","text":". "},{"text":"§7➣"},{"text":"§f "},[{"text":"§41234 "},{"text":"§4§ngoogle.com","clickEvent":{"action":"open_url","value":"https://google.com"}},{"text":"§4 1234"}]]

[festino]

Yeah, this is weird. Not a single bold code "§l" Also, is it still "hello google.com4 12345" in the chat?

[GitNether]

Yep, still the extra 4 and wrong colouring weirdly enough

[festino]

I will try to reproduce and fix it tomorrow

[festino]

I found another bug: the first style after any hex color was disappearing. I believe that is why bold was gone As before, I updated .jar: https://github.com/festino-mc-plugins/ClickableLinks/releases/tag/v1.2.2

[GitNether]

Color still buggy, but Bold works! :D

[festino]

Can you give me a minimal reproducible example? I could not reproduce the color bug Also, are you using Spigot or some other server core?

[GitNether]

Yes, Spigot. It seems like it only happens if there is a number after the link

[festino]

I couldn't come up with a message format that would reproduce "extra 4" bug, but I did reproduce the color bug. I hope it is fixed now: https://github.com/festino-mc-plugins/ClickableLinks/releases/tag/v1.2.2

[GitNether]

Weirdly still happens. The link resets the color, but only if theres numbers directly after, which is weird.

[GitNether]

Other than that it's looking fine, so thank you!

[GitNether]

Oh i just found this funny bug! Might help

[GitNether]

seems like the ampersand & is missing.

[festino]

Again, I couldn't reproduce this. For the latest bug fixes I used (/plugins/Essentials/config.yml): format: '&r&#00FF00&l<&7&l<&r<{DISPLAYNAME}&r&l&#00FF00>&l&7>&r> &3{MESSAGE}' I would like to get your format or minimal reproducible example to fix this

[GitNether]

Our current format: '{PREFIX} {deluxetags_tag} &r{NICKNAME} &7➣&f {MESSAGE}'

[festino]

format: '{PREFIX} &r{DISPLAYNAME} &7➣&f {MESSAGE}' T-T My configuration:

• Minecraft 1.20.1 (both vanilla and modded client)
• 3871-Spigot-d2eba2c-3f9263b
• EssentialsX v2.21.0-dev+73-2cb0af0
• EssentialsChat v2.21.0-dev+73-2cb0af0
• ClickableLinks v1.2.2
• No other plugins

[GitNether]

That's so weird lol EssentialsX and Chat 2.20.1

We're using Paper, but thats fundamentally Spigot too.

[festino]

I have no idea how can it be. I set up a server from scratch: Paper-196 EssentialsX and Chat 2.20.1 ClickableLinks 1.2.2 +used vanilla 1.20.1 client with default settings. I gave myself an op to get color permission.

Neither the default format nor '{PREFIX} &r{DISPLAYNAME} &7➣&f {MESSAGE}' could reproduce the bug

[GitNether]

Damn that's really weird. Some other plugin then must interfere with it, I suppose. Well, the main issue is fixed, and links are working properly now, so thank you for that and we can close this ticket finally!

[festino]

Ok. But I just want to polish the plugin: if you find any clues, then open a new ticket :)