search

fff-rs / juice

The Hacker's Machine Learning Engine
1.11k stars 76 forks source link

Convert juice benchtests to Criterion #192

Closed hweom closed 1 year ago

hweom commented 1 year ago

What does this PR accomplish?

Changes proposed by this PR:

Convert Juice benchtests to use Criterion.

Also, gate Coaster benchtests by a new nightly feature, otherwise they will fail to build under cargo bench on stable.

📜 Checklist

hweom commented 1 year ago

Gentle ping on this one.

drahnr commented 1 year ago

Should this be merged to your larger refactor branch rather than perf?

hweom commented 1 year ago

Should this be merged to your larger refactor branch rather than perf?

It is being merged into spearow:arch-refactor. I did it as a separate PR so that will get a perf diff for #186.