<nolink> and <span class="nolink"> should probably be respected as well, too.

ffhs / moodle-filter_fontawesome

A Moodle filter plugin to use fontawesome icons in the Moodle text editor

https://moodle.org/plugins/filter_fontawesome

2 stars 4 forks source link

<nolink> and <span class="nolink"> should probably be respected as well, too. #9

Closed lucaboesch closed 2 years ago

lucaboesch commented 2 years ago

Otherwise there's no way of showing persons the font awesome code you need to embed an icon.

voegii commented 2 years ago

Hi @lucaboesch

Thanks a lot for your issue and your pull request. I've added some PHPunit tests. Unfortunately some tests failed with your code. I have made another suggestion, which is also used in this way in other plug-ins. See https://github.com/ffhs/moodle-filter_fontawesome/tree/feature/respect-nolink-tags. Can you check this? If everything is ok for you, I will merge it.

Thank you and Greets Sascha

lucaboesch commented 2 years ago

Hi Sascha

Awesome. Your patch is clearly more sophisticated than mine, plus as well covered by tests. Feel free to incorporate yours.

I tested it and it just works.

(Loving that fontawesome irony with that double icon description for the same one btw.)

Best, Luca