search

ffmpeginteropx / FFmpegInteropX

FFmpeg decoding library for Windows 10 UWP and WinUI 3 Apps
Apache License 2.0
212 stars 53 forks source link

Fix subtitle style parsing #277

Closed lukasf closed 2 years ago

lukasf commented 2 years ago

I don't know how long this is broken, but FFmpeg does not return standard ass/ssa format lines anymore. Will need to test on more files, but this seems to fix it.

brabebhin commented 2 years ago

It tested with some of my files and it works fine. I don't have any advanced ASS/SSA files though

lukasf commented 2 years ago

During my testing on the WinRT branch, I again noticed the problem that our subtitle fonts get very big on low resolution files. That is because we currently set the font size in pixel unit. I changed this to percentage unit and now our font sizes are very close to other major players, regardless of the video resolution.

All these changes are on the WinRT branch already.

lukasf commented 2 years ago

The mplayerhq sample library has some good samples with styles and embedded fonts, by the way:

https://samples.mplayerhq.hu/Matroska/subtitles/

lukasf commented 2 years ago

D'oh I forgot to merge this. It was supposed to go into 1.0.1 before C++/WinRT merge...

brabebhin commented 2 years ago

Isn't this included in the cppwinrt branch anyway?

lukasf commented 2 years ago

Yes it is included. I just intended this to be released before winrt merge. But no big deal...

lukasf commented 2 years ago

Closing since this was already contained in WinRT PR.