ffmpeginteropx / FFmpegInteropX

FFmpeg decoding library for Windows 10 UWP and WinUI 3 Apps
Apache License 2.0
205 stars 52 forks source link

Add HDR check for Xbox #417

Closed softworkz closed 6 months ago

softworkz commented 6 months ago

The HDR check was non-functional on Xbox, which caused crashes when playing HDR videos without HDR being enabled on the xbox.

softworkz commented 6 months ago

Looks good. I added a PlatformInfo class, to prevent unneccessary API calls on PC platform.

I don't think there's any penalty involved in calling the non-applicable APIs. I'm extensively using them in the app code for automatic refresh rate and HDR mode switching. Anyway, the platform check will surely be useful for other xbox-specific tweaks where the situation is different.

Thanks.

lukasf commented 6 months ago

Meged. Thank you @softworkz