ffxivcode / AutoDuty

Dalamud Plugin for FFXIV - AutoDuty
98 stars 56 forks source link

[Bug] /ad repair is dangerous to use #620

Open McVaxius opened 4 weeks ago

McVaxius commented 4 weeks ago

What happened?

if you manually (or with snd) use /ad repair, it will occasionally just quit duties on its own afterwards until you invoke an /ad stop at some point while not in a duty

also sidenote. /ad repair will sometimes go into infinite loop trying to repair @ npc and never finishes or exits the menu. perhaps this is related? ive seen thsi happen from AD triggering its own repair too while doing its leveling stuff.

Version Number

0.0.0.173

Steps to reproduce the error

image

Relevant log output

nyet

Other relevant plugins installed

No response

Plugin config file

No response

Herculezz55 commented 3 weeks ago

hmm, there are several termination conditions in the repair helper that should prevent any of these things from happening, primarily the TimeOut stop and it should also be terminating if the helper is running and you are in a dungeon. I will look again at the helper and see what could be causing those termination conditions to fail

Herculezz55 commented 3 weeks ago

ok so it checks if the plugin state is navigating, which is set at the very beginning of a dungeon and unset after the last step is encountered, so unless something is prematurely removing the navigating state and/or causing AD to think it has completed the duty, I'm not sure why it would be doing this, also it looks like the timeout settings are set to 5m for self repair and 10m for city repair, so definitely shouldn't be getting stuck in a infinite loop. I will see if I can repro any of these situations and see what's going on.