search

fgl27 / SmartTwitchTV

A Twitch web client that works on Android TVs and web base systems
GNU General Public License v3.0
366 stars 28 forks source link

FFZ emotes not working. #109

Closed hunter1749 closed 2 years ago

hunter1749 commented 2 years ago

Describe the bug FFZ emotes don't display, but other like BTTV do.

To Reproduce Try to click on FFZ emotes button when typing in chat, but it says FFZ isn't on this channel.

Expected behavior FFZ emotes should work like in a browser on computer.

Additional context I saw someone else chat how they couldn't see FFZ emotes, perhaps it's somehow exclusive to xqc channel on this app.

fgl27 commented 2 years ago

If the problem is on one channel the problem is on the channel.

Add far as I know that steamer changed name that must had caused a issue.

Xqcow works wqc doesn't

https://www.frankerfacez.com/channel/xqcow https://www.frankerfacez.com/channel/xqc

Not an app problem but steamer and ffz problem

hunter1749 commented 2 years ago

Oh ok, so he should be fixing it then right? Or is there something I can do?

Js41637 commented 2 years ago

The issue is the app looks up FFZ emotes by their twitch name instead of their account id. This is an FFZ issue in that they are using the old account name for xqc so when it looks up xqc it finds no emotes but you can get around this by using their account id instead of their name.

The FFZ extension on desktop makes a request like this; https://api.frankerfacez.com/v1/room/id/71092938

This app is doing; https://api.frankerfacez.com/v1/room/xqc

I assume this is actually a pretty simple fix, just use the account id instead of their account name (or whatever it's called).

I was going to make a PR but I really don't understand the code enough to know what anything is. https://github.com/fgl27/SmartTwitchTV/blob/17a55c4ee985fbba961c4ea44e466f40e2653f80/app/specific/ChatLive.js#L770-L783

hunter1749 commented 2 years ago

Alright, thanks.