fgl27 / SmartTwitchTV

A Twitch web client that works on Android TVs and web base systems
GNU General Public License v3.0
366 stars 28 forks source link

Bug Report - Setting "Disable preview" doesn’t seem to work as expected #63

Closed AndMel87 closed 3 years ago

AndMel87 commented 3 years ago

Setting «Disable preview when multi-stream is enabled» from the Preview thumbnail player settings doesn’t seem to work as expected. The preview window still tries to load, and throws error message «Player unable to play due to player error. Error code:4001».

AndMel87 commented 3 years ago

Apk: 3.0.325 web: July 22 2021 Webview: 91.0.4472.164 Device: TCL - Percee TV Sdk: 26

fgl27 commented 3 years ago

To resolve this I need more info from the app take a picture or screenshot the setting option Blocked codecs and the about of the app and share here

As on bellow images yours will look different

Screenshot from 2021-07-31 09-03-46

Screenshot from 2021-07-31 09-02-17

AndMel87 commented 3 years ago

Attached:

about codecs

fgl27 commented 3 years ago

in relation to the settings option, "multi-stream" is the for way multistream, something that yours device doesn't support and you see the below warning when you try to use it

That option will only prevent the preview from show when multistream is enabled

Multistream warning

Screenshot from 2021-08-01 06-16-45

fgl27 commented 3 years ago

Regarding the error 4001 there reason is "Caused by a decoder initialization failure", because yours device only supports two players at the same time, you can see that on the value "Max instances: 2".

The app know that you can only use two and ca n prevent the preview from show, I just need to add a new check for it, when I do I close this.

fgl27 commented 3 years ago

I have added the bellow warning, it will show only once the first time it detects that you are trying to start more player then what the device supports

Screenshot from 2021-08-01 07-42-37

hunter1749 commented 3 years ago

in relation to the settings option, "multi-stream" is the for way multistream, something that yours device doesn't support and you see the below warning when you try to use it

That option will only prevent the preview from show when multistream is enabled

Multistream warning

Screenshot from 2021-08-01 06-16-45

Is there an option that would disable the "Your device only supports 2 codec instances" message to show like that? For me it now shows almost every time I just normally open a new stream (so even if there aren't multiple instances playing, but maybe it's still detecting that the preview thumbnail is being played at the same time and it shows the message on stream because of that?). This started happening about a week ago.

fgl27 commented 3 years ago

Are you sure you are see that warning? on the middle of the screen

That exactly string can only show if you try to open multistream, by clicking on the player controls or using the KEY_MEDIA_REWIND... the end of the string is "4-way multistream" only gets used here:

https://github.com/fgl27/SmartTwitchTV/blob/ca720dcd6491e90bfa49fb041685d5c71e8d5511/app/specific/PlayEtc.js#L2753

The other warning ends with "the preview", only shows once on the situation of the image of my previous post that I re-add below, then will only show again if you close the app and try again to use the preview and PP mode at same time but only once never again until the app is closed.

Screenshot from 2021-08-01 07-42-37

fgl27 commented 3 years ago

Screenshot_20210804-122856_SmartTV_Client_for_Twitch

Is possible to add more options to that settings options, but I would like to know if there is warnings shown when it shouldn't, so I can prevent it.

hunter1749 commented 3 years ago

Yes, I see it in the middle of the screen when I click on one of the livestreams. I can create another issue when I have time if needed,

fgl27 commented 3 years ago

click where?

hunter1749 commented 3 years ago

On the user menu (where livestreams of my followed channels are) I click on a livestream that I want to watch and the message appears in the middle of the screen when I select a livestream. Then that message disappears after a few seconds.

fgl27 commented 3 years ago

I can't understand how that shows

open a separated issue and make a video of the issue please