fgl82 / simplemenu

Simple menu launcher for the new Bittboy, Pocket Go, RetroFW and OpenDingux devices
156 stars 40 forks source link

Crashing in favorite mode / OD Beta #172

Closed K9-711 closed 3 years ago

K9-711 commented 3 years ago

simplemenu 9.2 on OD Beta. In favorite mode, keep pressing down, it goes to the last entry and then starting new from the first entry. Do the opposite way, keep up button pressing simpemenu crashes randomly when first entry is reached and it wants to go to the end of the list.

fgl82 commented 3 years ago

Thanks for reporting this. This happens when your favorites count is divisible by the number of games per page (for instance, 30 favorites with pages of 15), and it's a bug I'm aware of and fixing soon. If you add or remove a favorite it should work fine, but of course this is just a workaround.

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: K9-711 @.> Sent: Friday, July 16, 2021 9:51:03 AM To: fgl82/simplemenu @.> Cc: Subscribed @.***> Subject: [fgl82/simplemenu] Crashing in favorite mode / OD Beta (#172)

simplemenu 6.2 on OD Beta. In favorite mode, keep pressing down, it goes to the last entry and then starting new from the first entry. Do the opposite way, keep up button pressing simpemenu crashes randomly when first entry is reached and it wants to go to the end of the list.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/172, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHGQTCG4L27HOSCLWULTYATLPANCNFSM5APQSOFA.

K9-711 commented 3 years ago

Cool. Thank you. Have a great Weekend.

fgl82 commented 3 years ago

I was way off :) I've found the real cause of the bug, I think, and have fixed it. I'll probably publish the new version tomorrow.

fgl82 commented 3 years ago

Please check if the new release fixes your issue

K9-711 commented 3 years ago

Unfortunately it still crashes. To do a clean install I deleted the old simplemenu opk and the .simplemenu folder and then only copied section_groups folder and my favorites.sav

fgl82 commented 3 years ago

Can you list the steps you are following? I can't get it to crash after my fix..

fgl82 commented 3 years ago

Please be thorough so I can reproduce it, as in: 1) Start the console 2) SimpleMenu is/isn't the default 3) Open section XXXX 4) Etc.

fgl82 commented 3 years ago

Also, try letting it create an empty favorites.sav, just in case, and see if adding and removing works fine with that, maybe the old file is corrupted somehow

K9-711 commented 3 years ago

Ok, it also crashes when I add favorites to an empty favorites.sav by pressing X

What I do:

  1. Starting the console (OD Beta)
  2. SimpleMenu isn't set as default
  3. I' using Bog Cody theme, but also tried it with the standard OA theme
  4. In SimpleMenu I press L2 to enter favorites then A to open the list
  5. As soon I press the arrow up button SimpleMenu crashes and the 'desktop' shows up.
fgl82 commented 3 years ago

That's very strange, I definitely can't get it to happen. What I suggest you try: 1) Delete the old opk from the console 2) Delete/Rename the .simplemenu folder 3) Reboot the console 4) Download 9.3 5) Copy 9.3 to the console 6) Run it, 7) Important: if you see the text saying "Copying files, wait" on the first run, then you can be sure you are in 9.3 8) Exit simplemenu 9) Don't copy any of your old files except the section_group files 10) Delete last state.sav 11) Run simplemenu again 12) Go to a section that has games 13) Add a favorite with X 14) Press L2 15) Press A 16) Press Up

K9-711 commented 3 years ago

Just something I realized. When I'm enter the favorite mode and press Up key it crashes. But when I press right and / or left to jump pages and then keep pressing Up it doesn't crash.

Now I'll do your steps.

K9-711 commented 3 years ago

Ok, I followed exactly your steps. No crashing. I can add several games from different sections. No crashing.

fgl82 commented 3 years ago

ok, great, if it happens again, please let me know!

K9-711 commented 3 years ago

Thank you. It works now also after I copied my old favorite.sav

Another question. But I don't know of this is related to SimpleMenu. To run arcade games I'm using the latest FBA. In FBA I see the games list in full name thanks to the alias.txt. In SimpleMenu I can see all the full names on other sections like GBA. SNES but not for Arcade/FBA. It shows me only the filename of the rom.

fgl82 commented 3 years ago

This is in fact not related to simplemenu but with the name of your files. You can define an alias for any section, if you want, but ideally you'd have the right names for your non arcade files

K9-711 commented 3 years ago

I understand. Thanks fgl82 for everything.

fgl82 commented 3 years ago

I think I misunderstood your question, you were asking about aliasing the files in arcade sections. Check the config for those sections in arcades.ini You should have this exact path: aliasFile = /media/data/local/home/.simplemenu/alias.txt

K9-711 commented 3 years ago

Yeah, you mentioned; aliasFile = /media/data/local/home/.simplemenu/alias.txt For some reason I had aliasFile = /media/local/home/.simplemenu/alias.txt

With that correction it shows now the name of the games instead of the rom names. That's great.

fgl82 commented 3 years ago

The reason is that I had messed up in previous versions and left you with the wrong path ;)

K9-711 commented 3 years ago

I'm glad you ported SimpleMenu to OpenDIngux. (Beta) Otherwise I would have stayed with the stock formware. SImpleMenu adds a lot of value to the console. That's for sure.