search

fgl82 / simplemenu

Simple menu launcher for the new Bittboy, Pocket Go, RetroFW and OpenDingux devices
156 stars 40 forks source link

Quits/crashes when pressing select #174

Closed docwhat closed 3 years ago

docwhat commented 3 years ago

I just installed 9.3 on my RG350 and it's nice except for one issue:

If I press SELECT it causes SimpleMenu to either quit or crash. I suspect crash since it doesn't update the last_state.sav file.

I found a workaround by pressing B first and then SELECT works as expected.

I'm using Rogue 1.7.10 on the RG350P.

fgl82 commented 3 years ago

Hi, thanks for reporting this.

Which firmware are you using?

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Christian Höltje @.> Sent: Friday, July 23, 2021 1:26:14 AM To: fgl82/simplemenu @.> Cc: Subscribed @.***> Subject: [fgl82/simplemenu] Quits/crashes when pressing select (#174)

I just installed 9.3 on my RG350 and it's nice except for one issue:

If I press SELECT it causes SimpleMenu to either quit or crash. I suspect crash since it doesn't update the last_state.sav file.

I found a workaround by pressing B first and then SELECT works as expected.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/174, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHG76XS5KHIGH5MBAODTZDVONANCNFSM5A3IQVKQ.

materka commented 3 years ago

Same for me. Using Rogue CFW 1.7.14

docwhat commented 3 years ago

Which firmware are you using?

Stock for the RG350P. I'll add it to the initial report.

fgl82 commented 3 years ago

I'm not supporting stock, just Rogue and Beta

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Christian Höltje @.> Sent: Monday, July 26, 2021 12:51:21 PM To: fgl82/simplemenu @.> Cc: FGL82 @.>; Comment @.> Subject: Re: [fgl82/simplemenu] Quits/crashes when pressing select (#174)

Which firmware are you using?

Stock for the RG350P. I'll add it to the initial report.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/174#issuecomment-886820547, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHC25WN672YW2TCXIZTTZV77TANCNFSM5A3IQVKQ.

docwhat commented 3 years ago

My mistake: I'm using Rogue v1.7.10 -- I forgot I had updated for SimpleMenu.

fgl82 commented 3 years ago

Ah, good then :)

I'll look into this as soon as I have my rogue device, next week

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Christian Höltje @.> Sent: Monday, July 26, 2021 11:04:52 PM To: fgl82/simplemenu @.> Cc: FGL82 @.>; Comment @.> Subject: Re: [fgl82/simplemenu] Quits/crashes when pressing select (#174)

My mistake: I'm using Rogue v1.7.10 -- I forgot I had updated for SimpleMenu.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/174#issuecomment-887150805, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHB6WD6BAYUVOMWVAMLTZYH4JANCNFSM5A3IQVKQ.

docwhat commented 3 years ago

I just upgraded to Rogue v1.7.14 and the problem is there as well.

fgl82 commented 3 years ago

Yes, I don't expect the issue to be related to Rogue but to SM, somehow what I fixed before was broken again

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Christian Höltje @.> Sent: Tuesday, July 27, 2021 12:28:43 AM To: fgl82/simplemenu @.> Cc: FGL82 @.>; Comment @.> Subject: Re: [fgl82/simplemenu] Quits/crashes when pressing select (#174)

I just upgraded to Rogue v1.7.14 and the problem is there as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/174#issuecomment-887179326, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHAOT27JLRBGDRB4BH3TZYRWXANCNFSM5A3IQVKQ.

docwhat commented 3 years ago

It's been a while since I've written C code... would your build system allow easily adding in some kinds of unit tests, like check?

Seems like it would be a useful way to prevent regressions and test ideas.

fgl82 commented 3 years ago

I honestly have no idea, C is not the language I'm most familiar with and I had not touched it since college, so you can imagine how much I've forgotten or never learned at all.

Regarding test cases, even if there was something to do that, some of the code is tied to things only present on particular devices and has parts that are optionally compiled, so I'm not sure how feasible or useful it would even be.

From: Christian Höltje @.> Sent: Tuesday, July 27, 2021 1:31:52 PM To: fgl82/simplemenu @.> Cc: FGL82 @.>; Comment @.> Subject: Re: [fgl82/simplemenu] Quits/crashes when pressing select (#174)

It's been a while since I've written C code... would your build system allow easily adding in some kinds of unit tests, like checkhttps://libcheck.github.io/check/?

Seems like it would be a useful way to prevent regressions and test ideas.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/fgl82/simplemenu/issues/174#issuecomment-887658878, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN2JHD5IEMDE72LPNMT2P3TZ3NPRANCNFSM5A3IQVKQ.

docwhat commented 3 years ago

Optionally compiled is okay. You just put the test in the #ifdefs I think.

Specific devices (in an ideal world) are not an issue. These are unit tests and non-units (e.g. calls to the kernel or another process) are not covered in the concept of "unit tests"... ... ... ...in an ideal world. 😝

If I have time and spoons, I'll see if I can get a build env setup and take a look at it. I'm an SME (subject matter expert) in build systems but I haven't dealt with C in almost a decade and there are lots of new tools and toys.

fgl82 commented 3 years ago

Please verify if this still happens in the latest version

fgl82 commented 3 years ago

OK, it's been too long, closing this