search

fgm / filog

A fine logger package for Meteor.JS applications (client + server)
GNU General Public License v3.0
18 stars 6 forks source link

WIP Fix the v8 user info access logic #72

Closed fgm closed 3 years ago

fgm commented 5 years ago

The v8 user info access logic has been wrong since the first public version.

The first commit in this branch fixes the logic by reapplying the original pre-publish code, but with current v8 version, getThis() returns undefined in most cases, making it mostly useless. Look for a better way.

codecov[bot] commented 5 years ago

Codecov Report

Merging #72 into master will decrease coverage by 0.1%. The diff coverage is 33.3%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #72     +/-   ##
======================================
- Coverage    81.1%   81%   -0.2%     
======================================
  Files          16    16             
  Lines         510   511      +1     
  Branches       98    99      +1     
======================================
  Hits          414   414             
- Misses         90    91      +1     
  Partials        6     6
Impacted Files Coverage Δ
src/Processors/MeteorUserProcessor.ts 68% <33.3%> (-1%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe38355...ccef614. Read the comment docs.