search

fgrehm / devstep

Development environments powered by Docker and buildpacks
http://fgrehm.viewdocs.io/devstep
MIT License
195 stars 17 forks source link

POSTGRESQL_DATA custom data dir should also be injected in PG configuration file #79

Closed rvalyi closed 10 years ago

rvalyi commented 10 years ago

Configurable postgresql data directory was all the rage with https://github.com/fgrehm/devstep/pull/73 but without also injecting this custom directory inside Postgresql configuration before starting it was simply not working.

an error like that was happening if you set something different than the default value:

2014-09-05 19:39:17 UTC FATAL:  data directory "/shared/postgresql" does not exist

Sorry, I didn't catch that before because I was fixing that without remembering it in my base image. But now I tested well it really works with this patch.

fgrehm commented 10 years ago

This has been merged and released with the 0.2.0 version of the base image. Thanks for the patch!