search

fibo / trunx

Super Saiyan React components, son of awesome Bulma
MIT License
64 stars 14 forks source link

Field - Missing isHorizontal and no examples for isGrouped #13

Closed steph4nc closed 5 years ago

steph4nc commented 5 years ago

I see the is-horizontal class is missing as a prop on https://github.com/fibo/trunx/blob/master/src/component/Field.tsx https://bulma.io/documentation/form/input/

There is also no examples for isGrouped modifiers on Field on the storybook.

fibo commented 5 years ago

thanks for reporting it, you are helping me a lot. I will check it out.

steph4nc commented 5 years ago

No problem, I discover the missing things when I try and use them :-). I see now there is an example for isGrouped on the "Submit" "Cancel" buttons on the General Form page, but it would be nice if you also add an isGrouped example for input fields with a label.

fibo commented 5 years ago

I added missing props reported here and more stuff, available in version v0.12.0 published on the registry just now.

Please note that I had to remove label prop in Field component.

Now the Input component story is completed. About the example required, honestly I am just adding examples copied from Bulma docs, adding only few examples related to extra stuff like icons or React stuff (for example Input has an additional Ref section) when I find that it is mandatory to add something. At this first phase of the project I am copying from Bulma until 100% coverage is completed.

However, adding more examples is a good idea, but honestly I would need some help to define it better.