fiboa / specification

Field Boundaries for Agriculture (fiboa) - a specification that describes important properties of field boundaries
Apache License 2.0
10 stars 3 forks source link

Add units to property names #38

Closed m-mohr closed 1 month ago

m-mohr commented 3 months ago

Related Issue(s): None

Proposed Changes:

Rename area to area_ha and perimeter to perimeter_m.

It was brought up yesterday that the properties could include the units to be more explicit. We couldn't really decide so opening this for discussions (I think yesterday we had two no, two yes and some neutrals). Please vote with thumbs up/down.

PR Checklist:

jacobsn commented 2 months ago

A few thoughts:

m-mohr commented 2 months ago
  • If we are going to append units to every variable, I wonder if we'd end up with some cases where that's actually more confusing.

That's a compelling argument to me. How would we expose slightly less "simple" units? Percent? $lm \cdot m^{−2}$ ... Then it gets inconsistent leaving them out there, so overall it might be better to keep them out of the names.

m-mohr commented 1 month ago

@cholmes What's your feeling as the initiator of this idea? I tend towards closing this right now...

cholmes commented 1 month ago

Yeah, let's close it - just wanted to raise the discussion since it came up, but seems better to keep as it is.