What has been done to verify that this works as intended?
Opened Edit and upload screens and it did not crash
Why is this the best possible solution? Were any other approaches considered?
We do not use InstanceSyncTask but we would like to extened ODKs screens for upload and edit.
So, I just exited (Killed) that task.
We could make changes in how InstanceSyncTask work, so that it does not crash or We could remove all the places that InstanceSyncTask is being called but this would require large amount of unneeded changes.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
Yes, Instructions are on #494
Before submitting this PR, please make sure you have:
[ ] run ./gradlew checkAll and confirmed all checks still pass OR confirm CircleCI build passes and run ./gradlew connectedDebugAndroidTest locally.
Closes #494
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
We do not use InstanceSyncTask but we would like to extened ODKs screens for upload and edit. So, I just exited (Killed) that task.
We could make changes in how InstanceSyncTask work, so that it does not crash or We could remove all the places that InstanceSyncTask is being called but this would require large amount of unneeded changes.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
Yes, Instructions are on #494
Before submitting this PR, please make sure you have:
./gradlew checkAlland confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTestlocally.