search

filecoin-project / go-f3

Golang implementation of Fast Finality for Filecoin (F3)
Apache License 2.0
12 stars 7 forks source link

fix(log): demote log level to DEBUG on skipping forwards based on cert #724

Closed hanabi1224 closed 1 month ago

hanabi1224 commented 1 month ago

When bootstrapping a Forest or Lotus node from scratch with the latest snapshot (mostly on CI), F3 downloads certificates from instance 0 and floods stdout with tons of skipping forwards based on cert.

This PR proposes demoting its log level to DEBUG as it does not seem to be as important as other INFO logs under f3.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.01%. Comparing base (322dc35) to head (9db8a7c). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/724/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #724 +/- ## ========================================== - Coverage 75.23% 75.01% -0.22% ========================================== Files 69 69 Lines 6928 6928 ========================================== - Hits 5212 5197 -15 - Misses 1306 1317 +11 - Partials 410 414 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/724?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [host.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/724?src=pr&el=tree&filepath=host.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-aG9zdC5nbw==) | `63.85% <100.00%> (-1.81%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/724/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)