filecoin-project / go-f3

Golang implementation of Fast Finality for Filecoin (F3)
Apache License 2.0
12 stars 7 forks source link

Rename OhShitStore™ to `powerstore` #740

Closed masih closed 3 weeks ago

masih commented 3 weeks ago

Cosmetic renaming of the powerstore.

masih commented 3 weeks ago

@rjan90 I am not sure if the logs from OhShitStore are mentioned anywhere in F3 SP guides. We probably want to rename them if there is any.

rjan90 commented 3 weeks ago

@rjan90 I am not sure if the logs from OhShitStore are mentioned anywhere in F3 SP guides. We probably want to rename them if there is any.

No, we currently do not have them mentioned in the guide. But I plan to cover the meaning of these two log lines:

I will change the naming for those.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.99%. Comparing base (8497653) to head (8ea2d3a). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
f3.go 33.33% 2 Missing :warning:
internal/powerstore/powerstore.go 75.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/filecoin-project/go-f3/pull/740/graphs/tree.svg?width=650&height=150&src=pr&token=6uD131t7gs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)](https://app.codecov.io/gh/filecoin-project/go-f3/pull/740?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) ```diff @@ Coverage Diff @@ ## main #740 +/- ## ========================================== - Coverage 75.08% 74.99% -0.09% ========================================== Files 70 70 Lines 6939 6939 ========================================== - Hits 5210 5204 -6 - Misses 1317 1321 +4 - Partials 412 414 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/filecoin-project/go-f3/pull/740?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project) | Coverage Δ | | |---|---|---| | [internal/powerstore/powerstore.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/740?src=pr&el=tree&filepath=internal%2Fpowerstore%2Fpowerstore.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-aW50ZXJuYWwvcG93ZXJzdG9yZS9wb3dlcnN0b3JlLmdv) | `61.86% <75.00%> (ø)` | | | [f3.go](https://app.codecov.io/gh/filecoin-project/go-f3/pull/740?src=pr&el=tree&filepath=f3.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project#diff-ZjMuZ28=) | `61.53% <33.33%> (-1.47%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/filecoin-project/go-f3/pull/740/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=filecoin-project)