search

filecoin-project / go-fil-markets

Shared Implementation of Storage and Retrieval Markets for Filecoin Node Implementations
Other
78 stars 59 forks source link

Retrieval checkForActiveDeal is too aggressive #753

Closed magik6k closed 1 year ago

magik6k commented 1 year ago

I'm not sure why exactly we want to stop duplicate retrievals for the same piece, but checkForActiveDeal should at least permit retrievals for the same piece with different selectors.

Being able to only do a single retrieval per piece in parallel severely limits tools like https://github.com/filecoin-project/lotus/pull/9382.

dirkmc commented 1 year ago

Looks like it was implemented as a requirement of https://github.com/filecoin-project/lotus/issues/5443

I agree though, there's not really a good reason to prevent multiple concurrent deals.

hannahhoward commented 1 year ago

honestly yall can do whatever you want. go-fil-markets retrieval client is ONLY used by Lotus. It should probably move directly into the Lotus repo.

everybody else uses FilClient.