Closed wesfloyd closed 2 years ago
Hey @wesfloyd! Thanks for the issue report. I agree that the error message could be more describing in this context, and that we could describe better that a fresh wallet needs to have some funds (or DataCap) sent to it to be initialized/recognized by the chain.
I also think this error should be caught a bit earlier, instead of halfway through the lotus client deal
flow. It seems like we do not check if the actor (address in this case) is on chain before starting the uiLoop
:
https://github.com/filecoin-project/lotus/blob/e3f1eb29a14c7acb198e21b86aba1ada74c2cbb1/cli/client.go#L547-L565
So it only errors out when we get to this part in the uiLoop
when checking if the given address has a datacap:
https://github.com/filecoin-project/lotus/blob/e3f1eb29a14c7acb198e21b86aba1ada74c2cbb1/cli/client.go#L640-L642
Checklist
Latest release
, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Lotus component
Lotus Version
Describe the Bug
To reproduce: Attempting to create a Lotus deal with no FIL in my wallet I encountered the error "resolve address f1qim...jjy: actor not found"
Expected result: Error message would inform the user they have insufficient FIL in their wallet. E.g. "Insufficient funds in wallet for this transaction"
Actual result: Error message does not communicate the user's issue (mistake) "ERROR: resolve address f1qim...jjy: actor not found"
Logging Information
Repo Steps
Run '...'
Do '...'
See error '...' ...
Run: attempt to create a Lotus deal with no FIL in the wallet: "lotus client deal"
See "ERROR: resolve address f1qim...jjy: actor not found"