Ensure `AdvanceDeadline` doesn't skip important end-of-deadline steps - Githubissues

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.

Other

86 stars 102 forks source link

Ensure `AdvanceDeadline` doesn't skip important end-of-deadline steps #1348

Closed wadealexc closed 3 years ago

wadealexc commented 3 years ago

Reference: https://github.com/filecoin-project/specs-actors/blob/834add95b29a8a173f99927b853e7510b186631e/actors/builtin/miner/miner_state.go#L1130-L1139

This shortcut may bypass important operations, like:

The PoStSubmissions reset in ProcessDeadlineEnd: https://github.com/filecoin-project/specs-actors/blob/834add95b29a8a173f99927b853e7510b186631e/actors/builtin/miner/deadline_state.go#L869-L870
Popping expired sectors: https://github.com/filecoin-project/specs-actors/blob/834add95b29a8a173f99927b853e7510b186631e/actors/builtin/miner/miner_state.go#L1157-L1158