search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

Migration on simulated network #1350

Closed ZenGround0 closed 3 years ago

ZenGround0 commented 3 years ago

Use the new simulation framework to 1) generate realistic entropy within a state for migrating 2) continue simulating after migration to demonstrate common case network operations continue working on the migrated state.

codecov-io commented 3 years ago

Codecov Report

Merging #1350 (e429671) into master (19bfc47) will decrease coverage by 0.0%. The diff coverage is 0.0%.

@@           Coverage Diff            @@
##           master   #1350     +/-   ##
========================================
- Coverage    64.9%   64.9%   -0.1%     
========================================
  Files          81      81             
  Lines        8194    8195      +1     
========================================
  Hits         5325    5325             
- Misses       1977    1978      +1     
  Partials      892     892
ZenGround0 commented 3 years ago

@Stebalien @anorth I'm not exactly sure who to tag for review here given recent team changes. This PR only impacts testing frameworks so it might not be critical enough for either of you to review.

ZenGround0 commented 3 years ago

That is, use a v2 VM and v2 sim to start, then upgrade, then use a v3 VM and sim, initialised with the same (upgraded) blockstore to keep going. Maybe at some point that would require abstracting over the simulator API.

FYI this was my original idea but I backed out of it when I realized I would need to do non-trivial transformations on internal simulation state to go between v2 and v3 sims. This problem might not be so bad in the future if the sim framework does not add new functionality and stays stable between subsequent version changes. However in an ideal world we will be adding simulation functionality so the current approach doesn't get in the way of improvement.