search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

skip calculating hash if not check, or remove param #1364

Closed austinabell closed 3 years ago

austinabell commented 3 years ago

in getting a msig transaction, if the checkHash is not set, the hash is calculated and gas charged even if the proposal hash is nil. Every use of this function sets checkHash to true, so this issue could be to remove that parameter to reduce confusion if not being planned to be used.

https://github.com/filecoin-project/specs-actors/blob/c7ea99141c44e83b7b3856d0dc5833ae2c5e50d4/actors/builtin/multisig/multisig_actor.go#L513