search

filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.
Other
86 stars 102 forks source link

Publish valid deals in PublishStorageDeals message #1375

Closed jennijuju closed 3 years ago

jennijuju commented 3 years ago

Currently the market actor validates each deal, if one of the deals fails validation, the whole message fails. One of the validation is checking if the deal's start epoch has already passed and due to network's mpool congestion issue, it is possible that by the time a PublishStorageDeals message lands on-chain, the deal has already expired even though the message was sent beforehand.

It would be nice to only fail the invalid deals and have the valid one to be published successfully.

jennijuju commented 3 years ago

@dkkapur Could you please add the link to the FIP discussion or FIP itself once created?

ZenGround0 commented 3 years ago

FIP discussion happening here: https://github.com/filecoin-project/FIPs/issues/142

ZenGround0 commented 3 years ago

Closed by https://github.com/filecoin-project/specs-actors/pull/1487