filecoin-project / specs-actors

DEPRECATED Specification of builtin actors, in the form of executable code.

Other

86 stars 102 forks source link

Add gas to test vm #1408

Closed ZenGround0 closed 3 years ago

ZenGround0 commented 3 years ago

Closes #1266

I'm aiming for correctness to filecoin protocol / lotus vm now but it is not dangerous if we miss something in review. All inconsistencies externalized in test vectors will register as failures when ran against lotus (which I will then debug and fix) before releasing them as conformance tests.

codecov-commenter commented 3 years ago

Codecov Report

Merging #1408 (d02c103) into master (5114581) will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1408   +/-   ##
======================================
  Coverage    69.9%   69.9%           
======================================
  Files          72      72           
  Lines        7773    7773           
======================================
  Hits         5438    5438           
  Misses       1444    1444           
  Partials      891     891

arajasek commented 3 years ago

Broadly looks good. Will look in a bit more detail after a rebase (it's currently a bit confusing to look at diff).

ZenGround0 commented 3 years ago

Since we are all quite busy right now I went ahead and merged to unblock myself more quickly because existing review was thorough, this PR only impacts testing code, and gas calculation implementation errors will only become more apparent as we evaluate test vectors against lotus.