Actors Testing - that will be used to validate changes we made for SnapDeals implementation

[ZenGround0]

Description

Add VM tests to the actors/tests package that exercise the ProveCommitUpdateReplica method

Success cases:

• Happy path where sector update works
• power assertions
• Check that PoSt still works

Error cases:

• Fail updating sector with deals already
• Fail with invalid proof and batch sizes
• Fail when deals cannot activate
• Fail unproven & faulty sectors
• Deadline & partition incorrect

Done criteria

• Handle all these cases
• Due diligence finding other cases and including in tests

Dependencies

• [x] https://github.com/filecoin-project/specs-actors/issues/1511

Ongoing work

Not yet started

[arajasek]

Add a test for insufficient pledge when it goes up

[arajasek]

Check that in the happy path, your sector still gets faulty if post missed, and still gets recovered and such

[arajasek]

Add a test that actually has a batch -- some sectors in the same partition, others not.

[arajasek]

Test that sectors are still extensible and terminatable.

[arajasek]

edited by @jennijuju

(didnt realize i have so many typos in our slack messages lmao) @jennijuju asks:

now seems like we removed ReplaceCapacity completely, what will happen if:

• having a cc sector that's a replacement for a cc upgraded sector
• complete pre-commit
• network upgrade to v15
• whats the expected behaviour for provecommit? does it match the code?
• will the sectorkeyinfo be added to this new sector during migration?

[arajasek]

Add to TestFullPathSuccess

// TODO: miss a post, lose power
// miss another, get slashed
// submit post, recover

// TODO: update another sector, and immediately miss post, lose power
// submit post, recover

[arajasek]

More for TestUnhealthySectorFailure

More variants: testing that unproven, and terminated sectors fail.

[anorth]

@Kubuxu do you have testing points to contibute?

[arajasek]

Closed in #1552, though more tests welcome