search

files-community / Files

Building the best file manager for Windows
https://files.community
MIT License
33.18k stars 2.12k forks source link

Bug: Some of the icons in the sidebar may have a black background #14993

Open hishitetsu opened 4 months ago

hishitetsu commented 4 months ago

Description

I confirmed this happens when Windows version is 10 and DPI scaling is set to 150%. It doesn't occur when DPI scaling is set to 100%.

150% DPI scaling: image

100% DPI scaling: image

Steps To Reproduce

  1. Set DPI scaling to 150%.
  2. Launch Files.
  3. Observe the sidebar

Requirements

Make the background transparent.

Files Version

3.3.0.0

Windows Version

10.0.19045.4170

Log File

n/a

yaira2 commented 4 months ago

Does clearing the thumbnail cache resolve this?

hishitetsu commented 4 months ago

Does clearing the thumbnail cache resolve this?

No.

yaira2 commented 4 months ago

I can't repro this issue in Windows 11, is it only an issue in Windows 10?

hishitetsu commented 4 months ago

I can't repro this issue in Windows 11, is it only an issue in Windows 10?

Yes.

yaira2 commented 4 months ago

Does it also occur at higher scales? We might need to cap the requested size for the pinned items in Windows 10. Alternatively, we can make the black background transparent at runtime.

hishitetsu commented 4 months ago

Oddly enough, I found that this only occurs when the scale is 150%. It doesn't occur at 125% or 175%.

yaira2 commented 4 months ago

That's interesting, perhaps they don't provide a size for 150% in which case we should skip to 175% on Windows 10.

Sicquze commented 3 months ago

I have same problem on 100% DPI

yaira2 commented 3 months ago

I have same problem on 100% DPI

That's likely unrelated, in most cases that's a Windows bug and can be resolved by clearing the thumbnail cache.

yrifl commented 3 months ago

It occur to me when my DPI scaling is 100% or 125%.

yrifl commented 3 months ago

I don't have 150% dpi scale.

0x5bfa commented 3 months ago

@yrifl Can you try erasing cache?

yrifl commented 3 months ago

I have tried cleaning the thumbnail cache, and rebuild it.

hishitetsu commented 3 months ago

@Sicquze @yrifl can you upload a screenshot?

Sicquze commented 3 months ago

@Sicquze @yrifl can you upload a screenshot?

image

Sicquze commented 3 months ago

That's likely unrelated, in most cases that's a Windows bug and can be resolved by clearing the thumbnail cache.

Nope, it didn't work for me.

hishitetsu commented 3 months ago

This is a widget, not the sidebar. In any case, Windows 10 seems to have a black background for icons of certain sizes.

Sicquze commented 3 months ago

This is a widget, not the sidebar. In any case, Windows 10 seems to have a black background for icons of certain sizes.

It's the same in sidebar

jieran233 commented 2 months ago

I have Windows 10.0.19045, and I set custom scaling as 100% in Advance scaling options because I am using KVM switch before monitor, Windows identified my monitor scaling to 175% by mistake. I can conform the bug. This bug exists at almost everywhere in Files which referenced this icon, or at least in sidebar, title of tab, homepage, %USERPROFILE% (exactly, this sub-item of the icon set. e.g. smaller desktop icon looks like a blue desktop but bigger one has a folder with blue desktop, and the bug only exists on the smaller one). This cannot resolve by clearing thumbnail cache. Sorry for my poor English.

david03130 commented 1 month ago

I have both a Windows 10 (10.0.19045.4412) and Windows 11 machine with the same version of Files (3.4.1.0) and the W10 one has this same black background in the Desktop and Images directories (I don't remember seeing it anywhere else). I have DPI scaling at 100%. imagen