search

files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
34.78k stars 2.21k forks source link

Feature: Added support for assigning a custom name when creating a new shortcut #16506

Closed ferrariofilippo closed 2 days ago

ferrariofilippo commented 1 week ago

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

  1. Click on New
  2. Click on Shortcut
  3. Try to break the modal

Notes At the moment the Name is updated whenever the destination path changes.

Or alternatively, we only auto fill the name if the field is empty.

I think this may not work as expected: let's say a user selects SomePath/FileA, then the name will be set to File_A. If now the destination is changed to SomePath/File_B, the name should not be updated according to above (because the field would not be empty).

Screenshot 2024-11-21 214958

yaira2 commented 4 days ago

@ferrariofilippo can you add some space between the location text box and the name section?

ferrariofilippo commented 4 days ago

Which one is better?

12dp image

8dp image

yaira2 commented 2 days ago

@ferrariofilippo let's go with 12px for now.