files-community / Files

A modern file manager that helps users organize their files and folders.
https://files.community
MIT License
35.52k stars 2.26k forks source link

Feature: Removed toolbar from homepage #16589

Closed Lamparter closed 1 month ago

Lamparter commented 1 month ago

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Saw toolbar is hidden
0x5bfa commented 1 month ago

ShowToolbar is completely different setting here. I don't think this works when you switch between tabs.

yaira2 commented 1 month ago

ShowToolbar is completely different setting here. I don't think this works when you switch between tabs.

This is correct

Lamparter commented 1 month ago

ShowToolbar is completely different setting here. I don't think this works when you switch between tabs.

It worked when I tried it

yaira2 commented 1 month ago

This will cause the toolbar to show even if the user turned it off from settings.

yaira2 commented 1 month ago

@Lamparter you can do this by modifying the toolbar visibility in MainPage.xaml.

Visibility="{x:Bind converters:MultiBooleanConverter.AndConvertToVisibility(SidebarAdaptiveViewModel.PaneHolder.ActivePaneOrColumn.InstanceViewModel.IsPageTypeNotHome, ViewModel.ShowToolbar), Mode=OneWay}" />
yaira2 commented 1 month ago

Looking good! Can you please remove the header from the toolbar control now that it's no longer used?

Lamparter commented 1 month ago

What do you mean?

yaira2 commented 1 month ago

In InnerNavigationToolbar.xaml.